[REVIEW] enable per-thread default stream in gpu ci #5673
Conversation
|
Can one of the admins verify this patch? |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
| if [[ ${BUILD_MODE} == "pull-request" ]]; then | ||
| $WORKSPACE/build.sh clean libcudf cudf dask_cudf benchmarks tests | ||
| $WORKSPACE/build.sh clean libcudf cudf dask_cudf benchmarks tests --ptds | ||
| else | ||
| $WORKSPACE/build.sh clean libcudf cudf dask_cudf benchmarks tests -l | ||
| $WORKSPACE/build.sh clean libcudf cudf dask_cudf benchmarks tests -l --ptds | ||
| fi |
There was a problem hiding this comment.
@dillon-cullinan I assume the build mode is "pull-request" when CI is running against a PR. What is the else clause here used?
There was a problem hiding this comment.
For branch builds (merge commits + nightlies), we make sure to build the legacy code as well.
There was a problem hiding this comment.
Got it. Legacy code is gone so we can likely remove that option, but seems like this is good to go then. Thanks!
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #5673 +/- ##
===============================================
+ Coverage 86.16% 87.82% +1.65%
===============================================
Files 72 72
Lines 12485 15477 +2992
===============================================
+ Hits 10758 13592 +2834
- Misses 1727 1885 +158
Continue to review full report at Codecov.
|
kkraus14
added
5 - Merge After Dependencies
and removed
3 - Ready for Review
|
Waiting to merge until tests have been run with RMM with the new PTDS enabled |
|
rerun tests |
kkraus14
added
5 - Ready to Merge
Always build and test with per-thread default stream enabled, as discussed in #5614.
@harrism @jrhemstad @kkraus14