Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix merge typecast scope issue #3850

Merged
merged 2 commits into from
Jan 21, 2020
Merged

[WIP] Fix merge typecast scope issue #3850

merged 2 commits into from
Jan 21, 2020

Conversation

brandon-b-miller
Copy link
Contributor

Fixes #3848

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner January 21, 2020 14:41
shwina
shwina approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work zeroing in on this so quickly @brandon-b-miller!

@codecov
Copy link

codecov bot commented Jan 21, 2020 •
edited
Loading

Codecov Report

Merging #3850 into branch-0.12 will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.12    #3850   +/-   ##
============================================
  Coverage        86.73%   86.73%           
============================================
  Files               50       50           
  Lines             9610     9610           
============================================
  Hits              8335     8335           
  Misses            1275     1275
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 91.98% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed33cb8...e1aa499. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Jan 21, 2020

@brandon-b-miller is this good to merge?

@brandon-b-miller
Copy link
Contributor Author

Should be good to go :)

@brandon-b-miller brandon-b-miller added 5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API. labels Jan 21, 2020
@ayushdg
Copy link
Member

ayushdg commented Jan 21, 2020

Thanks @brandon-b-miller! I built from your branch and it fixes the previously seen memory issues.

@kkraus14 kkraus14 merged commit 0b4b944 into rapidsai:branch-0.12 Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Possible memory leak when merging DataFrames
4 participants
@brandon-b-miller @shwina @ayushdg @kkraus14