-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Update Errors in docs: 10min-cudf-cupy.ipynb and Dataframes section #3618
[REVIEW] Update Errors in docs: 10min-cudf-cupy.ipynb and Dataframes section #3618
Conversation
added warnings ignore code and removed warnings shown in our docs
added PR rapidsai#3618
Codecov Report
@@ Coverage Diff @@
## branch-0.12 #3618 +/- ##
===============================================
+ Coverage 87.39% 89.55% +2.16%
===============================================
Files 49 51 +2
Lines 9390 13293 +3903
===============================================
+ Hits 8206 11904 +3698
- Misses 1184 1389 +205
Continue to review full report at Codecov.
|
fixed error in dict syntax
How come Codecov is reporting changes in test coverage? These all seem to be doc / notebook changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@beckernick, would you be able to take a look at this? 🙂 |
Nice catch on the small dataframe docstring error. This LGTM also. With that said, @taureandyernv those dlpack warnings are not superfluous. They are providing materially relevant information. It might be nice to add a line indicating that cuDF will throw a warning as a reminder to check if you need to transpose your data before using the dlpack interface. I'd not go as far as saying it's necessary since transposing is discussed in the current text. |
removed the removal of warnings
@beckernick , great point to keep the warnings as that's the case. I changed the code to no longer ignore the warnings. |
rerun tests |
Solves #3617 by adding an ignore warnings line in the code.
Also solves #3638 dict syntax error in example
Currently, dlpack() warnings show up a couple of times in our documentation notebook https://rapidsai.github.io/projects/cudf/en/0.11.0/10min-cudf-cupy.html#