Added Imbalanced Tree Benchmarks for Transforms #18032
Open
+126
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamarrr
added
feature request
github-actions
bot
added
libcudf
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
A6000:
A100:
|
|
/ok to test |
ttnghia
reviewed
Feb 20, 2025
| // Construct expression that chains additions like (((a + b) + c) + d) | ||
| std::string const op = "+"; | ||
| std::string expression; | ||
| if (reuse_columns) { |
ttnghia
reviewed
Feb 20, 2025
| // child column reference | ||
| }; | ||
|
|
||
| template <typename key_type, TreeType tree_type, bool reuse_columns, bool Nullable> |
There was a problem hiding this comment.
Except key_type, can we use runtime parameters (benchmark axis) instead of template parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request follows up on #18023 and adds a benchmark for comparing imbalanced trees for transforms against AST and binaryops.
Checklist