Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to run pylibcudf tests #17882

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Add script to run pylibcudf tests #17882

merged 2 commits into from
Feb 4, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 31, 2025

Description

This is a small change adding a script to run pylibcudf tests, like we have for other Python libraries in this repository.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested review from a team as code owners January 31, 2025 13:33
@bdice bdice changed the base branch from branch-25.02 to branch-25.04 January 31, 2025 13:33
@bdice bdice removed request for a team, vyasr, ttnghia and mroeschke January 31, 2025 13:33
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2025
@bdice
Copy link
Contributor Author

bdice commented Feb 4, 2025

@KyleFromNVIDIA Could you review when you have a moment?

vyasr
vyasr approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the main benefit of this structure that we can reuse this scripts in devcontainers? I vaguely remember that being the motivation, and if so I'm OK with it. Otherwise it seems like we're dispersing logic across more files for little benefit.

@bdice
Copy link
Contributor Author

bdice commented Feb 4, 2025

Yes, the purpose of this is to eventually help with making devcontainers commands that can run tests easily. And it's important for uniformity with the other scripts that were added for this and other reasons (I think they're used for DLFW testing internally?).

@bdice
Copy link
Contributor Author

bdice commented Feb 4, 2025

/merge

@rapids-bot rapids-bot bot merged commit 81c383c into rapidsai:branch-25.04 Feb 4, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@Matt711 Matt711 Matt711 approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA was automatically assigned from rapidsai/packaging-codeowners

Assignees

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @vyasr @Matt711