Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Multi-input & Scalar Support for Transform UDFs #17881

Merged
merged 28 commits into from
Feb 13, 2025
Merged

Added Multi-input & Scalar Support for Transform UDFs #17881

merged 28 commits into from
Feb 13, 2025

Conversation

lamarrr
Copy link
Contributor

@lamarrr lamarrr commented Jan 31, 2025 •
edited
Loading

Description

This merge request implements multi-input and scalar support for UDF transforms.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 31, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. Java Affects Java cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jan 31, 2025
@lamarrr lamarrr added feature request New feature or request breaking Breaking change labels Jan 31, 2025
@vyasr vyasr changed the base branch from branch-25.02 to branch-25.04 January 31, 2025 19:36
@lamarrr lamarrr changed the title Multi transform udfs Added Multi-input & Scalar Support for Transform UDFs Feb 3, 2025
@lamarrr lamarrr marked this pull request as ready for review February 5, 2025 13:10
@lamarrr lamarrr requested review from a team as code owners February 5, 2025 13:10
Matt711
Matt711 requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python looks good, but I have some suggestions. And I'd like to know what @vyasr thinks too.

python/pylibcudf/pylibcudf/tests/test_transform.py Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_transform.py Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_transform.py Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_transform.py Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_transform.py Show resolved Hide resolved
Matt711
Matt711 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lamarrr

ttnghia
ttnghia approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java approval.

@lamarrr
Copy link
Contributor Author

lamarrr commented Feb 13, 2025

/merge

@rapids-bot rapids-bot bot merged commit 7914858 into rapidsai:branch-25.04 Feb 13, 2025
111 of 112 checks passed
@lamarrr lamarrr mentioned this pull request Feb 13, 2025
Open
3 tasks
@lamarrr lamarrr deleted the multi-transform-udfs branch February 13, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@vyasr vyasr vyasr approved these changes

@ttnghia ttnghia ttnghia approved these changes

@Matt711 Matt711 Matt711 approved these changes

Assignees

@lamarrr lamarrr

Labels
breaking Breaking change feature request New feature or request Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lamarrr @vyasr @ttnghia @Matt711 @davidwendt