Expose JSON reader options to builder in pylibcudf #17866
+308
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
Python
shrshi
added
non-breaking
mroeschke
reviewed
Jan 29, 2025
|
/ok to test |
|
/ok to test |
mroeschke
reviewed
Jan 30, 2025
| def mixed_types_as_string(self, val: bool) -> Self: ... | ||
| def na_values(self, vals: list) -> Self: ... | ||
| def nonnumeric_numbers(self, val: bool) -> Self: ... | ||
| def normalize_single_quotes(self, val: bool) -> Self: ... |
There was a problem hiding this comment.
nit: document normalize_single_quotes in python cudf.read_json docstring.
There was a problem hiding this comment.
Documented normalize_single_quotes and delimiter. Will add a docstring for the remaining parameters as well.
There was a problem hiding this comment.
Added documentation for the remaining extra parameters as well.
mroeschke
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds all JsonReaderOptionsBuilder to pylibcudf.
Checklist