-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mixed equality/conditional semi/anti joins #10037
Implement mixed equality/conditional semi/anti joins #10037
Conversation
To reviewers (@karthikeyann and @davidwendt) I would recommend waiting to review until #9917 is merged. I've opened this to allow the Spark team to start testing but this PR currently shows twice the changeset it needs. |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10037 +/- ##
================================================
+ Coverage 10.37% 10.42% +0.04%
================================================
Files 119 119
Lines 20149 20607 +458
================================================
+ Hits 2091 2148 +57
- Misses 18058 18459 +401
Continue to review full report at Codecov.
|
…and get first working prototype of semi join.
…uality and conditional tables.
58c16f2
to
5f0378e
Compare
Yeah we can look into that. We'll have to make a call on what sort of performance hit is acceptable for the compile-time improvement, I can look at previous nullate PRs to assess how we've decided that in the past. |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake changes LGTM
@gpucibot merge |
This depends on #9941 and #10037. Adds Java bindings for mixed left semi join and mixed left anti join. Authors: - Jason Lowe (https://github.com/jlowe) Approvers: - Alessandro Bellina (https://github.com/abellina) - Thomas Graves (https://github.com/tgravescs) - Jim Brennan (https://github.com/jbrennan333) URL: #10040
This PR is a follow-up to #9917 and should be merged after that PR. This resolves #9695 and resolves #5401. The implementation here is only a first pass, but in the interest of prioritizing a working feature for the upcoming release I'm postponing making various additional changes (including some breaking ones).