Some methods were not honoring custom Connection Timeouts #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 28, 2017
| @@ -179,7 +179,7 @@ def save(nsc) | |||
| end | |||
| xml.add_element(as_xml) | |||
|
|
|||
| response = APIRequest.execute(nsc.url, xml, '1.2') | |||
| response = APIRequest.execute(nsc.url, xml, '1.2', { timeout: nsc.timeout, open_timeout: nsc.open_timeout }) | |||
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
| @@ -157,7 +157,7 @@ def initialize(name, full_name, id = -1, enabled = true, scope = Scope::SILO) | |||
| def self.load(nsc, name, scope = Scope::SILO) | |||
| xml = nsc.make_xml('RoleDetailsRequest') | |||
| xml.add_element('Role', { 'name' => name, 'scope' => scope }) | |||
| response = APIRequest.execute(nsc.url, xml, '1.2') | |||
| response = APIRequest.execute(nsc.url, xml, '1.2', { timeout: nsc.timeout, open_timeout: nsc.open_timeout }) | |||
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
| @@ -159,7 +159,7 @@ def rescan_assets(connection) | |||
| # | |||
| def self.load(connection, id) | |||
| xml = %(<AssetGroupConfigRequest session-id="#{connection.session_id}" group-id="#{id}"/>) | |||
| r = APIRequest.execute(connection.url, xml) | |||
| r = APIRequest.execute(connection.url, xml, '1.1', { timeout: connection.timeout, open_timeout: connection.open_timeout }) | |||
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were four methods that had non-standard direct calls to
APIRequest.executecausing the custom set timeouts to be ignored.The following methods have been updated to use the
Connection::timeout:AssetGroup.loadRole.loadRole::saveSite::scan