-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very rough+small start, demoed a few weeks ago with VoiceOver. #15026
Conversation
Looks/sounds awesome. I wonder if we could make the screen reader changes directly to rex-text's table generation directly instead of modifying all of the tables directly in framework - that might reduce the effort of getting an MVP released 🤔 |
'Name,', | ||
'Current Setting,', | ||
'Required,', | ||
'Description,.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion, table additions for punctuation may be reasonable to implement as an option passed to the Rex::Text::Table
base on a if screen reading
is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, exactly where I was thinking made the most sense to put this capability.
Closing this for now until there's more feedback in the Metasploit Framework discussion 👍 |
Thanks for your contribution to Metasploit Framework! We've looked at this pull request, and we agree that it seems like a good addition to Metasploit, but it looks like it is not quite ready to land. We've labeled it What does this generally mean? It could be one or more of several things:
We would love to land this pull request when it's ready. If you have a chance to address all comments, we would be happy to reopen and discuss how to merge this! |
Replacing I get mixed results running these through TTS programs:
|
EDIT: this is in reference to this Metasploit Framework discussion.
This was a hackathon project I did in early 2020 (also explains why this fork+branch is WAY behind current Framework) where I used the built-in macOS screen reader. With limited time (hackathon!), I looked at improving three problems I noticed right away:
I put my work behind a new
msfconsole
commandline option:-s
. Then I made some improvements (hopefully), such as adding commas/punctuation to create pauses andNIL
to convey that a field was empty. Then I juxstaposed some common commands with "before" and "after" video clips, where "before" would be how VoiceOver currently (or in early 2020, anyway) would readmsfconsole
output, and "after" would be running the same command but in a session ofmsfconsole -s
where I had tried to make it better. Here's some of those clips (MAKE SURE TO UNMUTE EACH CLIP! :P ):starting the console up (wanted to still read the data around module counts, but skip the ASCII banner stuff)
BEFORE
h-start-before.mp4
AFTER
h-start-after.mp4
hosts
commandBEFORE
h-hosts-before.mp4
AFTER
h-hosts-after.mp4
listing a handler's advanced options
BEFORE
h-advopts-before.mp4
AFTER
h-advopts-after.mp4