Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very rough+small start, demoed a few weeks ago with VoiceOver. #15026

Closed
wants to merge 1 commit into from

Conversation

pbarry-r7
Copy link
Contributor

@pbarry-r7 pbarry-r7 commented Apr 10, 2021

EDIT: this is in reference to this Metasploit Framework discussion.

This was a hackathon project I did in early 2020 (also explains why this fork+branch is WAY behind current Framework) where I used the built-in macOS screen reader. With limited time (hackathon!), I looked at improving three problems I noticed right away:

  1. Reading useless stuff
  2. Reading without appropriate pause
  3. No indication of missing data

I put my work behind a new msfconsole commandline option: -s. Then I made some improvements (hopefully), such as adding commas/punctuation to create pauses and NIL to convey that a field was empty. Then I juxstaposed some common commands with "before" and "after" video clips, where "before" would be how VoiceOver currently (or in early 2020, anyway) would read msfconsole output, and "after" would be running the same command but in a session of msfconsole -s where I had tried to make it better. Here's some of those clips (MAKE SURE TO UNMUTE EACH CLIP! :P ):

starting the console up (wanted to still read the data around module counts, but skip the ASCII banner stuff)

BEFORE

h-start-before.mp4

AFTER

h-start-after.mp4

hosts command

BEFORE

h-hosts-before.mp4

AFTER

h-hosts-after.mp4

listing a handler's advanced options

BEFORE

h-advopts-before.mp4

AFTER

h-advopts-after.mp4

@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Apr 12, 2021

Looks/sounds awesome. I wonder if we could make the screen reader changes directly to rex-text's table generation directly instead of modifying all of the tables directly in framework - that might reduce the effort of getting an MVP released 🤔

Comment on lines +594 to +597
'Name,',
'Current Setting,',
'Required,',
'Description,.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion, table additions for punctuation may be reasonable to implement as an option passed to the Rex::Text::Table base on a if screen reading is enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, exactly where I was thinking made the most sense to put this capability.

@adfoster-r7 adfoster-r7 self-assigned this Sep 30, 2021
@adfoster-r7
Copy link
Contributor

Closing this for now until there's more feedback in the Metasploit Framework discussion 👍

@adfoster-r7 adfoster-r7 added the attic Older submissions that we still want to work on again label Oct 27, 2021
@github-actions
Copy link

Thanks for your contribution to Metasploit Framework! We've looked at this pull request, and we agree that it seems like a good addition to Metasploit, but it looks like it is not quite ready to land. We've labeled it attic and closed it for now.

What does this generally mean? It could be one or more of several things:

  • It doesn't look like there has been any activity on this pull request in a while
  • We may not have the proper access or equipment to test this pull request, or the contributor doesn't have time to work on it right now.
  • Sometimes the implementation isn't quite right and a different approach is necessary.

We would love to land this pull request when it's ready. If you have a chance to address all comments, we would be happy to reopen and discuss how to merge this!

@github-actions github-actions bot closed this Oct 27, 2021
@bcoles
Copy link
Contributor

bcoles commented Nov 23, 2022

Replacing print_ method progress indicators with words may also be a good idea.

I get mixed results running these through TTS programs:

[+] Something good happened
[-] Something bad happened
[*] Something notable happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attic Older submissions that we still want to work on again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants