-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MC-1261] Implement ConnectWise plugin with 10 actions #1430
Conversation
7f04f36
to
611ef08
Compare
Validator is failing because of missing icon.png and extension.png files. @wjohnstone-r7 @blaxminarayan-r7 Could you provide them? Also there are some warning regarding improper date format in help.md file but it's just validator issue - date is in the correct format. |
5f5c9aa
to
b977c03
Compare
611ef08
to
d4bfcfb
Compare
d6d6f31
to
d42bd6d
Compare
16c7df9
to
9a75a62
Compare
d42bd6d
to
02b618c
Compare
@@ -0,0 +1,6 @@ | |||
BASE_URL = "https://api-na.myconnectwise.net/v4_6_release/apis/3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Connectwise can be onprem. So shouldnt this come from connection parameters input
02b618c
to
4b1c4fd
Compare
09a276d
to
f387195
Compare
3b585b6
to
3e8370f
Compare
7858f66
to
af7c7aa
Compare
* MC-1261 Implement ConnectWise plugin with 10 actions * MC-1261 Fix validator issues * MC-1261 Fix validator help.md issues * MC-1261 Add icon and extensions png's, fix unit test errors * MC-1261 Fix unit test errors #2 * MC-1261 Fix unit tests #3 * MC-1261 Rename _info to info in outputs * Resolve validation errors on timestamp string formats
* MC-1261 Implement ConnectWise plugin with 10 actions * MC-1261 Fix validator issues * MC-1261 Fix validator help.md issues * MC-1261 Add icon and extensions png's, fix unit test errors * MC-1261 Fix unit test errors #2 * MC-1261 Fix unit tests #3 * MC-1261 Rename _info to info in outputs * Resolve validation errors on timestamp string formats
Proposed Changes
Description
Describe the proposed changes:
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblekomand/python-3-37-slim-plugin
andkomand/python-3-37-plugin
make validate
which callsmdl
to linthelp.md
Functional Checklist
tests/
directory created withicon-plugin run -c sample $action > tests/$action.json
tests/$action_bad.json
icon-plugin run -T tests/example.json --debug --jq
icon-plugin run -T all --debug --jq
(use PR format at end)icon-plugin run -R tests/example.json --debug --jq
icon-plugin run -R all --debug --jq
(use PR format at end)Assessment
assessment.md