Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC-1261] Implement ConnectWise plugin with 10 actions #1430

Merged
merged 8 commits into from
Oct 13, 2022

Conversation

mgrandys-r7
Copy link
Contributor

@mgrandys-r7 mgrandys-r7 commented Sep 27, 2022

Proposed Changes

Description

Describe the proposed changes:

  • Initial plugin

PR Requirements

Developers, verify you have completed the following items by checking them off:

Testing

Unit Tests

Review our documentation on generating and writing plugin unit tests

  • Unit tests written for any new or updated code

In-Product Tests

If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:

  • Screenshot of job output with the plugin changes
  • Screenshot of the changed connection, actions, or triggers input within the InsightConnect workflow builder

Style

Review the style guide

Functional Checklist

  • Work fully completed
  • Functional
    • Any new actions/triggers include JSON test files in the tests/ directory created with icon-plugin run -c sample $action > tests/$action.json
    • Tests should all pass unless it's a negative test. Negative tests have a naming convention of tests/$action_bad.json
    • Unsuccessful tests should fail by raising an exception causing the plugin to die and an object should be returned on successful test
    • Add functioning test results to PR, sanitize any output if necessary
      • Single action/trigger icon-plugin run -T tests/example.json --debug --jq
      • All actions/triggers shortcut icon-plugin run -T all --debug --jq (use PR format at end)
    • Add functioning run results to PR, sanitize any output if necessary
      • Single action/trigger icon-plugin run -R tests/example.json --debug --jq
      • All actions/triggers shortcut icon-plugin run -R all --debug --jq (use PR format at end)

Assessment

assessment.md

@mgrandys-r7 mgrandys-r7 changed the title MC-1261 Implement ConnectWise plugin with 10 actions [MC-1261] Implement ConnectWise plugin with 10 actions Sep 27, 2022
@mgrandys-r7 mgrandys-r7 force-pushed the MC-1261_ConnectWise_1.0.0 branch from 7f04f36 to 611ef08 Compare September 28, 2022 09:35
@mgrandys-r7
Copy link
Contributor Author

Validator is failing because of missing icon.png and extension.png files. @wjohnstone-r7 @blaxminarayan-r7 Could you provide them?

Also there are some warning regarding improper date format in help.md file but it's just validator issue - date is in the correct format.

@mgrandys-r7 mgrandys-r7 force-pushed the MC-1261_ConnectWise_1.0.0 branch 2 times, most recently from d6d6f31 to d42bd6d Compare September 30, 2022 10:15
@blaxminarayan-r7 blaxminarayan-r7 force-pushed the develop branch 2 times, most recently from 16c7df9 to 9a75a62 Compare October 5, 2022 11:21
@blaxminarayan-r7 blaxminarayan-r7 force-pushed the MC-1261_ConnectWise_1.0.0 branch from d42bd6d to 02b618c Compare October 5, 2022 11:36
@@ -0,0 +1,6 @@
BASE_URL = "https://api-na.myconnectwise.net/v4_6_release/apis/3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connectwise can be onprem. So shouldnt this come from connection parameters input

@mgrandys-r7 mgrandys-r7 force-pushed the MC-1261_ConnectWise_1.0.0 branch from 02b618c to 4b1c4fd Compare October 7, 2022 11:27
@blaxminarayan-r7 blaxminarayan-r7 force-pushed the MC-1261_ConnectWise_1.0.0 branch from 09a276d to f387195 Compare October 11, 2022 14:41
@blaxminarayan-r7 blaxminarayan-r7 force-pushed the develop branch 2 times, most recently from 3b585b6 to 3e8370f Compare October 12, 2022 10:34
@blaxminarayan-r7 blaxminarayan-r7 force-pushed the MC-1261_ConnectWise_1.0.0 branch from 7858f66 to af7c7aa Compare October 13, 2022 13:39
@blaxminarayan-r7 blaxminarayan-r7 merged commit 52dcdf1 into develop Oct 13, 2022
blaxminarayan-r7 pushed a commit that referenced this pull request Oct 13, 2022
* MC-1261 Implement ConnectWise plugin with 10 actions

* MC-1261 Fix validator issues

* MC-1261 Fix validator help.md issues

* MC-1261 Add icon and extensions png's, fix unit test errors

* MC-1261 Fix unit test errors #2

* MC-1261 Fix unit tests #3

* MC-1261 Rename _info to info in outputs

* Resolve validation errors on timestamp string formats
blaxminarayan-r7 added a commit that referenced this pull request Oct 13, 2022
* MC-1261 Implement ConnectWise plugin with 10 actions

* MC-1261 Fix validator issues

* MC-1261 Fix validator help.md issues

* MC-1261 Add icon and extensions png's, fix unit test errors

* MC-1261 Fix unit test errors #2

* MC-1261 Fix unit tests #3

* MC-1261 Rename _info to info in outputs

* Resolve validation errors on timestamp string formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants