Add Switch to Next/Prev Split or Tab command #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @vlabo thanks for the PR, It does make sense! Could you update the docs folder regarding it: https://rioterm.com/docs/key-bindings#split-actions |
raphamorim
reviewed
Mar 2, 2025
| @@ -570,6 +570,32 @@ impl<T: EventListener + Clone + std::marker::Send + 'static> ContextManager<T> { | |||
| self.current_route = self.current().route_id; | |||
| } | |||
|
|
|||
| #[inline] | |||
| pub fn switch_to_next_split_or_tab(&mut self) { | |||
There was a problem hiding this comment.
everything looks good, could you just add one test for next and prev so we make sure it always work 🙏
There was a problem hiding this comment.
Done. Thanks for the patience.
|
Thank you for updating the docs @vlabo 🙏 |
raphamorim
approved these changes
Mar 2, 2025
There was a problem hiding this comment.
Nice! thank you @vlabo and thanks for the sponsorship too, I appreciate 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add two new commands
This allows to switch between splits and tabs with single key binding.
I understand if you dont want to merge this and leave it for the plugin system, when available.
Thanks for making this great software.