Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goreleaser): different terminfo paths for deb/rpm based distros #985

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

vedantmgoyal9
Copy link
Contributor

No description provided.

@vedantmgoyal9 vedantmgoyal9 mentioned this pull request Feb 24, 2025
@raphamorim raphamorim merged commit 52fc90a into raphamorim:main Feb 24, 2025
@vedantmgoyal9 vedantmgoyal9 deleted the patch-1 branch February 24, 2025 22:24
@devurandom
Copy link

I do not think this works. You're installing the terminfo file in text format into the /usr/share/terminfo directory that takes compiled terminfo files:

❯ file /usr/share/terminfo/r/rxvt
/usr/share/terminfo/r/rxvt: Compiled terminfo entry "rxvt"

❯ infocmp rxvt | head -n 2
#	Reconstructed via infocmp from file: /usr/share/terminfo/r/rxvt
rxvt|rxvt-color|rxvt terminal emulator (X Window System),

❯ file /usr/share/terminfo/r/rio
/usr/share/terminfo/r/rio: ASCII text

❯ infocmp rio
infocmp: couldn't open terminfo file /usr/share/terminfo/r/rio.

I can locally fix this by:

❯ tic -xe rio /usr/share/terminfo/r/rio

❯ infocmp rio
#	Reconstructed via infocmp from file: ~/.terminfo/r/rio
rio,

I assume you'll need to run a "post install" command. Maybe the scripts.postinstall example at https://goreleaser.com/customization/nfpm/ helps?

@vedantmgoyal9
Copy link
Contributor Author

@raphamorim
Copy link
Owner

Isn’t that only for darwin?

@vedantmgoyal9
Copy link
Contributor Author

vedantmgoyal9 commented Feb 25, 2025

actually, i made a dumb mistake. i bundled compiled terminfo files in macos app bundle but source terminfo in deb and rpms 🤦🏻‍♂️🤦🏻‍♂️🤦🏻‍♂️

@vedantmgoyal9
Copy link
Contributor Author

fixed in #986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants