-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use as default thin lto instead to use full lto #748
Conversation
* It gonna optimize more than full and it gonna resolve all the issue of compiling with lto and it gonna speedup the compiling process * That commit point to fix the issue of #737
Any idea why thin LTO resolves the compilation issues on Arch Linux? FWIW: briansmith/ring#1444 |
some dependencies isn't passing with full lto (because of undefined symbols) so we need to switch to thin seem much packages on aur use thin as patch aswell i can put a patch in the pkgbuild and we can leave the full lto on all project errors about full lto: https://paste.cachyos.org/p/eef0fd6.txt let me know what i need to do edit: i'm trying anyway to modify the pkgbuild of the guy for do the package rio-git, anyway i don't think is worth to use the flag what i think about your issue isn't needed to use
https://github.com/briansmith/ring/blob/main/Cargo.toml#L206 (they put i tried today to recompile the pkgbuild with the We need to consider the fat lto gonna try to do lto on deps too if the deps have issues we can't compile it like yesterday :) |
Yup, I think this should be solved on the Arch side of things instead of upstream. We can keep the fat LTO and use the workaround mentioned in briansmith/ring#1444 - that's what we do for most of the Arch packages these days. |
yeah, we can do that or switch the project to thin lto and remove the fat lto (isn't much safe as i said it do too lto on deps and other) or do a little patch on the pkgbuild to remove |
I gonna close the pull request as resolve for atleast arch linux management we can leave fat lto as default and leave the package managers fix that. |
Hello, I noticed issue #737, and after some investigation, I would like to suggest switching from full LTO to ThinLTO. This change will optimize the compilation process more effectively than full LTO, resolve the compilation issues associated with it, and speed up the overall compilation time.
Best Regards,
NextWorks