Add VI toggle for CTRL + SHIFT + SPACE on win (#496)

* add toggle vi mode for `windows` * update keybinding for windows vi mode * fix: add keybinding to wa impl * docs: update windows keybinding
raphamorim · Apr 28, 2024 · 536bc9b · 536bc9b
1 parent 369ce98
commit 536bc9b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/docs/docs/key-bindings.md b/docs/docs/key-bindings.md
@@ -38,7 +38,7 @@ language: 'en'
 | Action               | Key                                                         |
 | -------------------- | ----------------------------------------------------------- |
 | Open configuration   | `Control + Shift + Comma (,)`                               |
-| Toggle VI Mode       | `Alt + Shift + Space`                                       |
+| Toggle VI Mode       | `Control + Shift + Space`                                   |
 | Copy                 | `Control + Shift + C`                                       |
 | Paste                | `Control + Shift + V`                                       |
 | Create new window    | `Control + Shift + N`                                       |

diff --git a/frontends/rioterm/src/bindings/bindings_wa/mod.rs b/frontends/rioterm/src/bindings/bindings_wa/mod.rs
@@ -1031,6 +1031,7 @@ pub fn platform_key_bindings(
         // https://github.com/alacritty/alacritty/issues/2930
         // https://github.com/raphamorim/rio/issues/220#issuecomment-1761651339
         Key::Named(Backspace), Modifiers::CONTROL, ~BindingMode::VI; Action::Esc("\u{0017}".into());
+        Key::Named(Space), Modifiers::CONTROL | Modifiers::SHIFT, Action::ToggleViMode;
     );
 
     if use_navigation_key_bindings {

diff --git a/frontends/rioterm/src/bindings/bindings_winit/mod.rs b/frontends/rioterm/src/bindings/bindings_winit/mod.rs
@@ -1070,6 +1070,7 @@ pub fn platform_key_bindings(
         // https://github.com/alacritty/alacritty/issues/2930
         // https://github.com/raphamorim/rio/issues/220#issuecomment-1761651339
         Key::Named(Backspace), ModifiersState::CONTROL, ~BindingMode::VI; Action::Esc("\u{0017}".into());
+        Key::Named(Space), ModifiersState::CONTROL | ModifiersState::SHIFT; Action::ToggleViMode;
     );
 
     if use_navigation_key_bindings {