Skip unreachable node during collecting NodeBundles #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guangbochen
reviewed
Nov 24, 2021
bk201
reviewed
Nov 24, 2021
pkg/manager/manager.go
Outdated
| switch cond.Type { | ||
| case v1.NodeReady: | ||
| if cond.Status != v1.ConditionTrue { | ||
| break NODE_LOOP |
There was a problem hiding this comment.
My bad 🤯 🙇🏾♂️
Fixed!
We currently skip nodes with unavailable network and not ready kubelet. Nodes tainted with `node.kubernetes.io/unschedulable:NoSchedule` are tolerated. Signed-off-by: Weihang Lo <[email protected]>
|
Can we tag a new release for this fix? Thanks |
This was referenced Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently skip nodes with unavailable network and not ready kubelet.
Nodes tainted with
node.kubernetes.io/unschedulable:NoScheduleare tolerated.Related issue: harvester/harvester#1524
Any improvement is welcome.