-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.24] change windows calico setup to generate a sa token #2940
[1.24] change windows calico setup to generate a sa token #2940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits on error returns but looks good other than that!
6b886ce
to
7366581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, missed this one
NAME STATUS ROLES AGE VERSION INTERNAL-IP EXTERNAL-IP OS-IMAGE KERNEL-VERSION CONTAINER-RUNTIME
ec2amaz-ru7d335 Ready <none> 47s v1.24.0 10.0.1.198 <none> Windows Server 2019 Datacenter 10.0.17763.2928 containerd://1.6.4
ip-10-0-1-148 Ready control-plane,etcd,master 8h v1.24.0+rke2r1 10.0.1.148 <none> Ubuntu 20.04.2 LTS 5.4.0-1045-aws containerd://1.6.4-k3s1
ip-10-0-1-72 Ready <none> 8h v1.24.0+rke2r1 10.0.1.72 <none> Ubuntu 20.04.2 LTS 5.4.0-1045-aws containerd://1.6.4-k3s1 With the latest commit, it's working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed Changes
As part of the 1.24 service account token changes, RKE2 Windows agents can no longer start up due to the calico-node service account token missing since secrets aren't created by default for SAs in 1.24. This PR gets the calico-node service account and generates a token for it using the TokenRequest API.
This is caused by a change in Kubernetes 1.24, documented in the upstream changelog:
Types of Changes
bugfix
Verification
Provisioning testing as well as upgrading from 1.23 -> 1.24. Commit testing is passing using
b290b7925f9393c2ad935015cb4087631adfc2af
Linked Issues
#2939
Further Comments
The RKE2 kubelet on windows throws an error regarding the image credential provider bin directory missing. This doesn't stop the node from becoming ready but I will open an issue for it: #2958