Ignore Windows artifacts when creating Linux bundle #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: As reported in rancher#2883, currently Windows binaries are being bundled together with Linux ones, and as result polluting the users environment when installing RKE2 Solution: Ignore Windows scripts and binaries when creating the RKE2 Linux bundle. Signed-off-by: Jonnatan Jossemar Cordero <[email protected]>
jossemargt-3pillar
changed the title
briandowns
approved these changes
May 17, 2022
brandond
approved these changes
May 17, 2022
jossemargt-3pillar
added a commit
to jossemargt-3pillar/rke2
that referenced
this pull request
May 18, 2022
jossemargt-3pillar
added a commit
to jossemargt-3pillar/rke2
that referenced
this pull request
May 18, 2022
jossemargt-3pillar
added a commit
to jossemargt-3pillar/rke2
that referenced
this pull request
May 18, 2022
This was referenced May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2883, currently Windows binaries are being bundled together with Linux ones, and as result polluting the users environment when installing RKE2.
Proposed Changes
Update packaging scripts to ignore Windows artifacts when creating the RKE2 Linux bundle (
tar.gz)Types of Changes
RKE2 packaging
Verification
.exeand.ps1) shouldn't be present in RKE2 linux CI and releasetar.gzfilesLinked Issues
#2883
Further Comments