[Release-1.21] Get node name from metadata if AWS cloud provider is enabled #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2163) The AWS cloud provider expects the node name of a node to have a specific form. If the user sets the hostname of the of the underlying machine to a custom name, then the node will fail to bootstrap because the node will not have the expected name. With this change, the node name is fetched from the metadata endpoint to ensure it has the proper value. If this fails, then it will fallback to the hostname command. Signed-off-by: Donnie Adams <[email protected]>
briandowns
approved these changes
Nov 24, 2021
brandond
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS cloud provider expects the node name of a node to have a
specific form. If the user sets the hostname of the of the underlying
machine to a custom name, then the node will fail to bootstrap because
the node will not have the expected name.
With this change, the node name is fetched from the metadata endpoint to
ensure it has the proper value. If this fails, then it will fallback to
the hostname command.
Signed-off-by: Donnie Adams [email protected]
Backport for PR #2163