Added gotest templates, changed unit test naming #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
briandowns
approved these changes
Aug 12, 2021
brandond
approved these changes
Aug 12, 2021
vadorovsky
approved these changes
Aug 13, 2021
vadorovsky
suggested changes
Aug 13, 2021
Signed-off-by: dereknola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola [email protected]
Proposed Changes
Copied the custom gotests templates from k3s into rke2.
Renamed the existing unit tests to match Test_Unit style.
Added new unit test for images package... small codecov improvement.
Types of Changes
Testing
Verification
N/A
Linked Issues
#1611
Further Comments