Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch info and config calls around for proper headers to hit first #1612

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

luthermonson
Copy link
Contributor

@luthermonson luthermonson commented Aug 12, 2021

Proposed Changes

Flip Config/Info calls in the rke2-install.ps1 for proper headers to be sent first.

Types of Changes

flip two func calls

Verification

Linked Issues

Further Comments

@luthermonson luthermonson requested a review from a team as a code owner August 12, 2021 00:49
@luthermonson luthermonson requested a review from phillipsj August 12, 2021 00:49
@codecov-commenter
Copy link

Codecov Report

Merging #1612 (a5efaa4) into master (4996c02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1612   +/-   ##
======================================
  Coverage    7.78%   7.78%           
======================================
  Files          21      21           
  Lines        1863    1863           
======================================
  Hits          145     145           
  Misses       1696    1696           
  Partials       22      22           
Flag Coverage Δ
unittests 7.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4996c02...a5efaa4. Read the comment docs.

@luthermonson luthermonson merged commit 8d7310a into rancher:master Aug 12, 2021
@luthermonson luthermonson deleted the fix-rke2-install branch August 12, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants