Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using hardened dns images #1513

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented Aug 3, 2021

Signed-off-by: Manuel Buil [email protected]

Proposed Changes

This PR replaces the nodeCache and autoscaler default images with the hardened ones. To do so:

  • Replaces the helm chart with one that uses those images
  • Replaces the images in the airgap scripts
  • Removes busybox image because we use the nodeCache image to check if the dns service is up (netcat was installed there)

Types of Changes

Image replacement

Verification

Deploy enabling autoscaler (by default) and nodeCache and verify that the images are the new ones

Linked Issues

#1473

@manuelbuil manuelbuil requested a review from a team as a code owner August 3, 2021 07:15
@codecov-commenter
Copy link

Codecov Report

Merging #1513 (01075a1) into master (d3a43b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1513   +/-   ##
======================================
  Coverage    8.51%   8.51%           
======================================
  Files          21      21           
  Lines        1692    1692           
======================================
  Hits          144     144           
  Misses       1526    1526           
  Partials       22      22           
Flag Coverage Δ
unittests 8.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a43b5...01075a1. Read the comment docs.

@manuelbuil
Copy link
Contributor Author

node_local dns Cache has a bug in the image build

@manuelbuil manuelbuil changed the title Start using hardened dns images [WIP] Start using hardened dns images Aug 3, 2021
* Add helm chart using hardened images
* Replace images for airgap

Signed-off-by: Manuel Buil <[email protected]>
@manuelbuil manuelbuil force-pushed the dns_hardened_images branch from 01075a1 to dc073b5 Compare August 3, 2021 17:42
@manuelbuil manuelbuil changed the title [WIP] Start using hardened dns images Start using hardened dns images Aug 3, 2021
@manuelbuil manuelbuil merged commit 137cbc8 into rancher:master Aug 3, 2021
@manuelbuil manuelbuil deleted the dns_hardened_images branch August 10, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants