This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Move retry logic for scale from zero into rio #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxmc99
commented
Dec 22, 2019
stacks/rio-autoscaler-stack.yaml
Outdated
| @@ -7,7 +7,7 @@ services: | |||
| - '* autoscale.rio.cattle.io/servicescalerecommendations' | |||
| - '* rio.cattle.io/services' | |||
| - '* rio.cattle.io/services/status' | |||
| image: rancher/rio-autoscaler:v0.1.5 | |||
| image: daxl/rio-autoscaler:dev3 | |||
There was a problem hiding this comment.
Depends on rancher/rio-autoscaler#11
cbron
approved these changes
Dec 23, 2019
| @@ -2,6 +2,9 @@ package vsfactory | |||
|
|
|||
| import ( | |||
| "net" | |||
| "time" | |||
|
|
|||
| "github.com/solo-io/gloo/projects/gloo/pkg/api/v1/options/retries" | |||
|
|
|||
daxmc99
commented
Dec 23, 2019
| // Retry configuration for the envoy gateway (Gloo) https://www.envoyproxy.io/learn/automatic-retries | ||
| // for services scaled to zero | ||
| var overallTimeout = time.Second * 30 | ||
| var perTryTimeout = time.Second * 2 |
There was a problem hiding this comment.
This was what I saw as a decent timeout for each request. Ultimately I think this may need to be configurable based upon the service being scaled
This moves the retry logic for the scale from zero functionality into the Rio controller where it can be performed by the Envoy proxy (Gloo).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the retry logic for the scale from zero functionality into
the Rio controller where it can be performed by the Envoy proxy (Gloo).
Addresses #607