Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add patch-agent-tls-mode instruction #49

Closed
wants to merge 1 commit into from
Closed

feat: add patch-agent-tls-mode instruction #49

wants to merge 1 commit into from

Conversation

FrankYang0529
Copy link
Collaborator

@FrankYang0529 FrankYang0529 commented Feb 12, 2025 •
edited
Loading

harvester/harvester#7453

  1. Build with harvester-installer to create an ISO.
  2. Start first node.
  3. Check whether value of agent-tls-mode setting is system-store.
  4. Setup ssl-certificates setting.
  5. Create second node to join first node without error.

@FrankYang0529 FrankYang0529 requested a review from bk201 February 12, 2025 10:51
@bk201 bk201 requested a review from ibrokethecloud February 13, 2025 01:19
@bk201
Copy link
Member

bk201 commented Feb 13, 2025

We also need to handle the upgrade path from 1.4.1 -> 1.4.2.

@ibrokethecloud
Copy link
Contributor

we could just handle this via the rancherValues and setting the value https://github.com/rancher/rancher/blob/main/chart/values.yaml#L43

@FrankYang0529
Copy link
Collaborator Author

we could just handle this via the rancherValues and setting the value https://github.com/rancher/rancher/blob/main/chart/values.yaml#L43

Thanks for the suggestion. I checked Rancher code yesterday, but not sure how it passes value to here.

https://github.com/rancher/rancher/blob/5c3550f5532288b7fdbb5514cc49f2a148823e40/pkg/settings/setting.go#L62

I will update harvester-installer to check whether this can work. Thanks.

@FrankYang0529
Copy link
Collaborator Author

I will update harvester-installer to check whether this can work.

Confirm that agentTLSMode can work. Close the PR. Thanks.

@FrankYang0529 FrankYang0529 deleted the HARV-7453 branch February 13, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@ibrokethecloud ibrokethecloud Awaiting requested review from ibrokethecloud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYang0529 @bk201 @ibrokethecloud