Remove init node label #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kiefer Chang <[email protected]>
guangbochen
reviewed
Sep 28, 2022
|
This only fixes new clusters, we also need to fix promote scripts in harvester/harvester. |
If we can fix the promote scripts to add the related labels then we may consider keeping this label for the rancherd? |
I'll do some tests and report back. |
This was referenced Sep 29, 2022
|
Related issues: |
guangbochen
approved these changes
Sep 30, 2022
bk201
added a commit
to bk201/harvester-installer
that referenced
this pull request
Oct 5, 2022
Include rancherd update: rancher/rancherd#25. Signed-off-by: Kiefer Chang <[email protected]>
bk201
added a commit
to bk201/harvester-installer
that referenced
this pull request
Oct 5, 2022
Include rancherd update: rancher/rancherd#25. Signed-off-by: Kiefer Chang <[email protected]>
bk201
added a commit
to harvester/harvester-installer
that referenced
this pull request
Oct 6, 2022
Include rancherd update: rancher/rancherd#25. Signed-off-by: Kiefer Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest by the Rancher team to fix rancher/rancher#37462 (comment)