Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.4] Fix schemas leak #589

Merged
merged 2 commits into from
Jan 14, 2025
Merged

[v0.4] Fix schemas leak #589

merged 2 commits into from
Jan 14, 2025

Conversation

joshmeranda
Copy link
Contributor

backport #523

We neglect to remove schemas from s.schemas in s.doRemoveSchema which results in duplicate entries in s.schemas which are never removed. This introduces a memory leak of ~300 mb a week on a large rancher cluster.

rancher/rancher#47694

@joshmeranda joshmeranda requested a review from a team as a code owner January 14, 2025 15:32
crobby
crobby approved these changes Jan 14, 2025
View reviewed changes
Copy link

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me

@joshmeranda joshmeranda merged commit bf01b4d into rancher:release/v0.4 Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobby crobby crobby approved these changes

@tomleb tomleb tomleb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshmeranda @crobby @tomleb