Skip to content

Commit

Permalink
don't set finalize on namespace
Browse files Browse the repository at this point in the history
  • Loading branch information
Daishan Peng committed Dec 27, 2017
1 parent a212c8c commit c4e428e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lifecycle/object.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ func (o *objectLifecycleAdapter) create(metadata metav1.Object, obj runtime.Obje
metadata.SetAnnotations(map[string]string{})
}

metadata.SetFinalizers(append(metadata.GetFinalizers(), o.name))
if o.objectClient.GroupVersionKind().Kind != "Namespace" {
metadata.SetFinalizers(append(metadata.GetFinalizers(), o.name))
}
metadata.GetAnnotations()[initialized] = "true"

_, err = o.objectClient.Update(metadata.GetName(), obj)
Expand Down

0 comments on commit c4e428e

Please sign in to comment.