This repository has been archived by the owner on Jan 27, 2018. It is now read-only.
catalog fix #2
Merged
catalog fix #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/setup/setup.go
Outdated
| @@ -31,6 +31,7 @@ func Schemas(ctx context.Context, management *config.ManagementContext, schemas | |||
| Templates(schemas) | |||
| ClusterRegistrationTokens(schemas) | |||
| addUserAction(schemas) | |||
| addCatalogRefreshAction(schemas) | |||
There was a problem hiding this comment.
I'd prefer these two methods to be Users(schemas) and Catalogs(schemas) to match the style above
api/catalog/filter.go
Outdated
| catalogName := strings.Split(resource.ID, "-")[0] | ||
| // idk why current returns a url start with http:/ instead of http:// | ||
| // but this link is hacky | ||
| resource.Links["catalog"] = strings.Replace(path.Join(path.Dir(apiContext.URLBuilder.Current()), "catalogs", catalogName), "http:/", "http://", 1) |
There was a problem hiding this comment.
My eyes.... my poor eyes are bleeding. Add a method to URLBuilder for ResourceLinkByID(schema *Schema, id string)
added 2 commits
December 16, 2017 01:19
Fixed link to catalog, versionLinks, category, refreshAction and hiding versions from templates
|
rancher/norman#20 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.