Replace primary/secondary sort fields with an array of sort directives. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpromislow
requested review from
moio and
tomleb
and removed request for
a team
moio
previously approved these changes
Jan 15, 2025
tomleb
reviewed
Jan 15, 2025
|
This now depends on lasso PR 117 in order to improve the unit tests for |
ericpromislow
force-pushed
the
48092-sort-clusters
branch
from
559627d to
33cea4c
Compare
moio
approved these changes
Jan 16, 2025
tomleb
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows collection URLs to have a sort query that sorts on more than two fields
The use of
PrimaryFieldandSecondaryFieldis too limiting, and leads to unlikely edge-cases,like having a Secondary Field but no Primary Field. Better to just maintain parallel arrays of
fields and sort-orders.
Related to #48092