Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Github Actions #39

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Migrate to Github Actions #39

merged 2 commits into from
Apr 19, 2024

Conversation

thomasferrandiz
Copy link
Contributor

@thomasferrandiz thomasferrandiz commented Mar 20, 2024 •
edited
Loading

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@galal-hussein
Copy link
Contributor

Just one comment I have is that I don't think we need to remove image-push and image-manifest from the Makefile even if we are not going to use it in the github action, since operator still might want to use the Makefile for testing, we just need to align it with the github action parameters

@thomasferrandiz thomasferrandiz force-pushed the migrateToGHA branch 6 times, most recently from 9e6cfbe to 7075702 Compare March 22, 2024 14:05
@thomasferrandiz thomasferrandiz force-pushed the migrateToGHA branch 2 times, most recently from 19a3165 to 27e33ba Compare April 10, 2024 15:04
@thomasferrandiz thomasferrandiz merged commit 2fa229c into rancher:main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelbuil manuelbuil manuelbuil approved these changes

@galal-hussein galal-hussein Awaiting requested review from galal-hussein

@briandowns briandowns Awaiting requested review from briandowns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasferrandiz @galal-hussein @manuelbuil