Automate Qase 153, 151, and 87 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
eks-automation-2
branch
from
9bdf427 to
3d27538
Compare
Signed-off-by: Parthvi Vala <[email protected]>
thehejik
reviewed
Jan 23, 2025
hosted/eks/p1/p1_import_test.go
Outdated
| @@ -167,6 +167,23 @@ var _ = Describe("P1Import", func() { | |||
| updateTagsAndLabels(cluster, ctx.RancherAdminClient) | |||
| }) | |||
|
|
|||
| It("Add a nodegroup in EKS → Syncs to Rancher → Update cluster, the nodegroup is intact", func() { | |||
There was a problem hiding this comment.
Wouldn't be ASCII -> better?
Co-authored-by: Parthvi Vala <[email protected]> Co-authored-by: Tomas Hehejik <[email protected]> Signed-off-by: Parthvi Vala <[email protected]>
cpinjani
reviewed
Jan 23, 2025
| err = clusters.WaitClusterToBeUpgraded(ctx.RancherAdminClient, cluster.ID) | ||
| Expect(err).To(BeNil()) | ||
| Eventually(func() bool { | ||
| cluster, err = helper.UpdateCluster(cluster, ctx.RancherAdminClient, updateFunc) |
There was a problem hiding this comment.
Is UpdateCluster required again here ?
There was a problem hiding this comment.
Hmm, that shouldn't have been here. It is supposed to simply fetch the cluster. Let me fix that.
There was a problem hiding this comment.
cpinjani
reviewed
Jan 23, 2025
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
Co-authored-by: Chandan Pinjani <[email protected]> Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
cpinjani
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Checklist:
Special notes for your reviewer: