Simplify PerClusterState and include all states and cluster IDs #3287
+253
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
aruiz14
force-pushed
the
per-cluster-state-changes
branch
from
8e5b7d6 to
60b1e9c
Compare
aruiz14
force-pushed
the
per-cluster-state-changes
branch
from
60b1e9c to
edae80d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #3186
Depends on #3286
As stated in the previous description of the field, "ResourcePerClusterState is generated for each non-ready resource of the bundles". This makes it hard to obtain a complete picture of every resource from a GitRepo.
In fact, this information is not used in the Rancher UI at all, since it had to fallback to BundleDeployments in order to obtain an accurate list of resources.
This breaking change simplifies PerClusterState, by transforming it into a map of cluster IDs per state (aiming for minimal payload), hence removing irrelevant fields like "error", "message", "patch" and "transitioning" (which remain available in other
NonReadyandModifieddedicated fields as well as theConditions).