Update sort for numeric string values #9936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bisht-richa I've disconnected the PR from #9782. This is only a partial fix. Can you update the description with the bullet point this PR addresses? Thought we had also agreed that this work is additional churn given the user will revert back to the existing sort mechanisms when server side pagination comes in? |
|
Given #9936 (comment), closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify Sort function test for these two types of values in the table
How to test
IP addresses, e.g. in Pods and Node list, should be sorted numerically-octet-wise.
For number as strings can be tested in sort.js test