Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cluster detail machine and node lists are grouped correctly #13287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Feb 4, 2025

Summary

Fixes #13285

Occurred changes and/or fixed issues

  • the ResourceTable's used for rke1 nodes and rke2 machines incorrectly disabled grouping
  • grouping however was broken under the hood and showed them anyway
  • this was fixed in fixed in Add server-side pagination to home page cluster list #11663
    • specifically the addition of the if in
       computedGroupBy() {
         // If we're not showing grouping options we shouldn't have a group by property
         if (!this.showGrouping) { return null; } 
    
  • the fix here is to remove the groupable=false to ensure grouping can show

I've validated that the issue does not occur in 2.10-head

Areas or cases that should be tested

  • RKE1 and RKE2 clusters should show the pool and deployment groups when viewing the cluster detail pool tab list
  • The groups, if the user has permission, should contain scaling controls

Screenshot/Video

image

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

- their resource table elements turned these off
- this misconfiguration was ignored until grouping was fixed in rancher#11663
  - specifically the addition of the if in computedGroupBy
   ```
    computedGroupBy() {
      // If we're not showing grouping options we shouldn't have a group by property
      if (!this.showGrouping) {
        return null;
      }
   ```
@richard-cox richard-cox added this to the v2.11.0 milestone Feb 4, 2025
@richard-cox richard-cox requested a review from torchiaf February 4, 2025 18:16
@richard-cox richard-cox changed the title Ensure cluster detail manchine and node lists are grouped correctly Ensure cluster detail machine and node lists are grouped correctly Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaling buttons are absent
1 participant