Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Vue compiler warnings after upgrade to 3.5 #13279

Merged

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Feb 3, 2025

Summary

This resolves Vue compiler warnings that started appearing after the upgrade to Vue 3.5.

Fixes #13124

Occurred changes and/or fixed issues

  • Fix warnings about table structure
  • Fix warnings about defineEmits

Technical notes summary

It appears that this is a behavior that was introduced in to vuejs/core#12088. There's some debate as to whether or not the message is always valid, but it appeared simple enough for us to update our table usage to resolve the warning and clean up the console output.

Areas or cases that should be tested

The affected tables should be reviewed for regressions:

  • Diagnostics
  • AksNodePool
  • Saml
  • Principal

Areas which could experience regressions

The affected tables should be reviewed for regressions:

  • Diagnostics
  • AksNodePool
  • Saml
  • Principal

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.11.0 milestone Feb 3, 2025
@rak-phillip rak-phillip self-assigned this Feb 3, 2025
@rak-phillip rak-phillip merged commit 5f75ce5 into rancher:master Feb 4, 2025
49 checks passed
@rak-phillip rak-phillip deleted the task/13124-vue-compiler-warnings branch February 4, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve vue compiler warnings after bump to Vue 3.5
2 participants