Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Performance --> Pagination setting only enables post compatible check #11505

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Jul 22, 2024

Summary

Fixes #11497

Occurred changes and/or fixed issues

  • Ensure that on cancel of incompatible performance settings modal the checkbox remains unchecked
  • Do this by externally controlling the state of the checkbox in all scenarios

Areas or cases that should be tested

  • As per description, plus edge cases
  • Once pagination setting enabled refresh page and ensure checkbox continues to work as expected

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.10.0 milestone Jul 22, 2024
@richard-cox richard-cox self-assigned this Jul 22, 2024
@richard-cox richard-cox requested a review from aalves08 August 20, 2024 09:21
@richard-cox richard-cox marked this pull request as ready for review August 20, 2024 09:22
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Screen.Recording.2024-08-21.at.16.33.01.mov

@richard-cox richard-cox merged commit 8dbf707 into rancher:master Aug 21, 2024
30 checks passed
@richard-cox richard-cox deleted the fix-pag-setting branch August 21, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance: Server-side pagination setting is enabled when user hits cancel option
2 participants