Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS - fix container monitoring checkbox #11083

Merged

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #10965

Occurred changes and/or fixed issues

The 'container monitoring' checkbox should correspond to aksConfig.monitoring - previously it was just gating the visibility of the two log analytics inputs. This PR corrects that and adds a few unit tests.

Areas or cases that should be tested

  1. create an AKS cluster with container monitoring enabled, and log analytics workspace name/group set - the payload should include aksConfig.monitoring = true
  2. edit cluster and disable container monitoring - the payload should include aksConfig.monitoring = false, and aksConfig.logAnalyticsWorkspaceName and aksConfig.logAnalyticsWorkspaceGroup set to null

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md added this to the v2.9.0 milestone May 21, 2024
@mantis-toboggan-md mantis-toboggan-md changed the title fix container monitoring checkbox and add unit tests AKS - fix container monitoring checkbox May 21, 2024
Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and LGTM

@mantis-toboggan-md mantis-toboggan-md merged commit a666ee9 into rancher:master May 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2.9] AKS: Configuring Container Monitoring not working
2 participants