Extensions: Add hooks to support virtual clusters #11064
Merged
+256
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
changed the title
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
3 times, most recently
from
3225ac2 to
82fc100
Compare
|
@mantis-toboggan-md finally got this to pass gates - refactored as we discussed. |
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
from
82fc100 to
37c7477
Compare
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
from
71c0394 to
29ec9b5
Compare
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
from
29ec9b5 to
06756d1
Compare
aalves08
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Reviewing this, changes seem pretty self self-contained as it's targeting the provisioning.cattle.io.cluster. I assume that since this is experimental, we don't want to document it right now, but in the future, if we open it, we need to add it to the documentation.
One last remark would be around using modelExtensions instead of extending/reusing uiConfig 🤔
nevertheless, I would say that it LGTM
richard-cox
requested changes
Jan 24, 2025
nwmac
force-pushed
the
add-virtual-cluster-hooks
branch
from
8432344 to
1f0919e
Compare
mantis-toboggan-md
approved these changes
Jan 29, 2025
richard-cox
approved these changes
Jan 30, 2025
izaac
pushed a commit
to izaac/dashboard
that referenced
this pull request
Feb 3, 2025
* Add hooks to support virtual clusters * Fix lint issues * Refinements * Update for Vue 3 changes * Fix import * Minor tweaks * Fix bug causing e2e tests to fail * Fix lint issue * Rename internal properties and ensure they don't break clone/save * Ensure we generate types for the plugins package to give us access to mapDriver * Simpler approach * Fix lint issues and add type * Remove unused code * Revery unnecessary changes * Bug fix for finding model extension * Factor out string constant and add provider display method * Add experimental to API * Update typegen.sh to use SHELL_DIR var * Move type def * Fix lint issue * Address PR feedback * Update steve-class.js so we always get an array * Fix type definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11065
This PR adds several hooks for virtual cluster support.
The main change is a new extension API
addModelExtension- this is marked experimental for now - once we establish if we need any changes, we can remove that label.You can register model extensions and they are stored against a model type, e.g.
provisioning.cattle.io.cluster. There is a method on the Steve base class to retrieve all of the model extensions for a given model type. You can register multiple model extensions for a given model.Beyond that, it is up to a given model to decide how to use these model extensions - i.e. a model needs to define an API for them and explicitly wire that into itself. This ensures we have a defined API for extensibility, rather than allowing a model extension to do anything it wants.
In this PR, we write a model extension into the provisioning cluster model to support the needs of virtual clusters.
Risk wise, this PR is designed to minimise impact to existing code, so the risk is small.
Areas or cases that should be tested
These hooks will be tested by extensions.
Current e2e test should validate that the hooks do not break existing functionality.
Checklist