-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INT] Refactored some of the plugins - 3 #10946
Conversation
0567a51
to
10cb0a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c17c501
to
bbc9b01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. I just have one concern about how we export some of our directives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thought about naming, we could probably categorize all of our directives under shell/directives
.. this can be done as a future PR, I feel this PR has enough content in it already.
Summary
Fixes #10774
Refactored plugins to be Vue3 migration ready
Occurred changes and/or fixed issues
Refactored:
Technical notes summary
Areas or cases that should be tested
The entire application is affected since these plugins are globally used.
In particular:
Areas which could experience regressions
The entire application is affected since these plugins are globally used.
Screenshot/Video
Checklist