update developer docs #10901
Merged
update developer docs #10901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonasberhe23
force-pushed
the
update_docs
branch
from
55f6a98 to
1513bb0
Compare
richard-cox
requested changes
Apr 30, 2024
docusaurus/docs/testing/e2e-test.md
Outdated
| Note: When selecting an element be sure to use the attribute `data-testid`, even in case of lists where elements are distinguished by an index suffix. | ||
|
|
||
| ### Best Practices to keep in mind when writing tests | ||
|
|
||
| - When selecting an element be sure to use the attribute `data-testid`, even in case of lists where elements are distinguished by an index suffix. |
There was a problem hiding this comment.
Could we change this to request if the data-testid exist it should be used?
izaac
reviewed
Apr 30, 2024
yonasberhe23
force-pushed
the
update_docs
branch
from
1513bb0 to
95a2278
Compare
richard-cox
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #rancher/qa-tasks#1293
Occurred changes and/or fixed issues
Update docs to include best practices discussed with the UI team regarding how to utilize POs and cleaning up resources at the end of tests.
Checklist