-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port drone build tasks to gh workflows + actions #10874
Merged
richard-cox
merged 3 commits into
rancher:master
from
richard-cox:richard-drone-dashboard-pr
May 1, 2024
Merged
Port drone build tasks to gh workflows + actions #10874
richard-cox
merged 3 commits into
rancher:master
from
richard-cox:richard-drone-dashboard-pr
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove old drone build tasks (note - FOSSA will not be ported at this time, discussed in slack) - create generic setup composit action which can be used by multiple workflows - create generic lint, i18n-lint and unittest composit action which can be used by multiple workflows - create generic build-and-upload workflow which can be used by multiple workflows - trigger build-and-upload on merge to specific branch (TBD) - trigger build-and-upload on specific tags Also - changed name of yarn install:ci as it was used outside of ci Note - I'd have liked to group together the workflows used by the build, but things like workflow subfolders aren't supported
5143812
to
e3143f6
Compare
richard-cox
commented
Apr 26, 2024
richard-cox
commented
Apr 26, 2024
richard-cox
commented
Apr 26, 2024
richard-cox
commented
Apr 26, 2024
3ec34e1
to
0df4a95
Compare
0df4a95
to
411a9bf
Compare
nwmac
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
richard-cox
added a commit
to richard-cox/dashboard
that referenced
this pull request
May 13, 2024
…oard-pr Port drone build tasks to gh workflows + actions
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10633
Occurred changes and/or fixed issues
Also
install:ci
as it was used outside of ciNote
Examples
building from branch (with uploaded bits) - https://github.com/rancher/dashboard/actions/runs/8832322713
building from tag (with uploaded bit) - https://github.com/rancher/dashboard/actions/runs/8832309261
Technical notes summary
Areas or cases that should be tested
master
should upload tolatest
. Merges to other branches should upload to<branch name>
Checklist