Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
nwmac committed Jan 20, 2025
1 parent d96c899 commit 63ae9b5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
6 changes: 5 additions & 1 deletion shell/components/formatter/LiveExpiryDate.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ export default {
type: Object,
default: () => {}
},
missingKey: {
type: String,
default: 'generic.never',
}
},
data() {
Expand Down Expand Up @@ -77,7 +81,7 @@ export default {
/>
<span
v-else
v-t="'generic.never'"
v-t="missingKey"
class="text-muted"
/>
</template>
15 changes: 8 additions & 7 deletions shell/config/table-headers.js
Original file line number Diff line number Diff line change
Expand Up @@ -961,13 +961,14 @@ export const EXPIRES = {
};

export const LAST_USED = {
name: 'lastUsed',
value: 'lastUsedAt',
labelKey: 'tableHeaders.lastUsed',
align: 'left',
sort: ['lastUsedAt'],
width: 200,
formatter: 'LiveExpiryDate'
name: 'lastUsed',
value: 'lastUsedAt',
labelKey: 'tableHeaders.lastUsed',
align: 'left',
sort: ['lastUsedAt'],
width: 200,
formatter: 'LiveExpiryDate',
formatterOpts: { missingKey: 'generic.unknown' },
};

export const RESTART = {
Expand Down

0 comments on commit 63ae9b5

Please sign in to comment.