Release-1.17: Windows Installer: Do not attempt to install WSL #8111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We missed rebuilding the custom action when using the (development-only) `yarn wix`. Signed-off-by: Mark Yen <[email protected]>
The WSL installer has changed again, such that it always uses an MSI installer, so we cannot install it from within our installer. Rather than trying to work around this, just detect the situation and abort the install with a message so the user can manage it separately. This ensures that we do not have to detect network state, etc. If we wish to have the installer manage WSL installation in the future, it would be better to create an exe installer that bundles the MSI, and from there launch the WSL installer separately (outside of the Windows Installer database lock). Signed-off-by: Mark Yen <[email protected]>
We already do so (since 2ca4484), this just removes the extra unused knob. Turning off compression does not seem to make the build faster anyway. Signed-off-by: Mark Yen <[email protected]>
Since we no longer attempt to install WSL as part of our installer, we can remove the code that was used to do so. Signed-off-by: Mark Yen <[email protected]>
jandubois
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release-1.17 PR for #8110.
Original PR description: