Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorerframe fixes for win11: more workarounds for unpredictable menubar appearance on later 23H2 and 24H2 builds #1544

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

CyprinusCarpio
Copy link
Contributor

  • More workarounds for unpredictable menu bar appearance on later 23H2 and 24H2 versions

…ubar appearance on later 23H2 and 24H2 builds
@CyprinusCarpio
Copy link
Contributor Author

Again, less than surgical approach used. In the future, I may find what it is exactly about the WM_WININICHANGE message that fixes the problem, and do that more precisely, but for now I think it's sufficient to send this message and mitigate the one negative effect I identified during my testing.

Needs testing by @Anixx before merging.

@Anixx
Copy link
Contributor

Anixx commented Feb 15, 2025

I am on build 22631.4751 now and I do not experience any unpredictable menubar appearances with the older mod, only without it. At which build number did you first exeprience troubles on 23H2?

@Anixx
Copy link
Contributor

Anixx commented Feb 15, 2025

As to 24H2, I deleted that virtual machine, will need to install it anew...

@CyprinusCarpio
Copy link
Contributor Author

I am on build 22631.4751 now and I do not experience any unpredictable menubar appearances with the older mod, only without it. At which build number did you first exeprience troubles on 23H2?

Strange indeed. I'm testing on build 22631.4391 and the problem is the same as on 24H2: the menu bar doesn't want to stay put if it's the only toolbar, and it appears when the color theme changes or the resolution is changed (WM_SETTINGSCHANGE handler). Only after this message has been handled, does the menu bar stay if it's the only toolbar. Sending this message immediately is the first part of the solution. The second part is mitigating the problem the first part causes: that is the inability to save the layout of toolbars, if the menu bar was the only toolbar present when the window was opened.

@Anixx
Copy link
Contributor

Anixx commented Feb 15, 2025

Okay, I tried it and it does not work worse than the prevuous version on 23H2.

There is one glitch though, which, I believe existed in the prevuous version as well: upon change of the color scheme, the status bar in the folder windows of OpenShell (Classic Explorer) becomes white, so the windows should be re-opened. This is not the case when this mod is off:

изображение

When the option "Classic CabinetWClass background color" is off, this glitch does not appear.

@CyprinusCarpio
Copy link
Contributor Author

Alright, thanks for testing. So this can be merged. As for your report, I'll diagnose, and fix it in another PR one of these days.

@m417z m417z merged commit e2c7aef into ramensoftware:main Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants