Fix rinf check in equilib scaling
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinf is the inf norm of all scaled rows, so has length a%m not a%n. Basically same as ralna#211
jfowkes
approved these changes
Jun 19, 2024
mjacobse
added a commit
to mjacobse/spral
that referenced
this pull request
Jun 19, 2024
Arrays for testing the scaling functions with random matrices were only allocated once with the maximum dimensions of all possibly generated matrices. That makes it simple, but unfortunately also has the potential to hide possible bugs, as seen in ralna#211 and ralna#213. To improve the chance to detect such bugs, this reallocates the arrays to the exact dimensions for each current test case.
jfowkes
pushed a commit
that referenced
this pull request
Jun 19, 2024
Arrays for testing the scaling functions with random matrices were only allocated once with the maximum dimensions of all possibly generated matrices. That makes it simple, but unfortunately also has the potential to hide possible bugs, as seen in #211 and #213. To improve the chance to detect such bugs, this reallocates the arrays to the exact dimensions for each current test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rinfis the inf norm of all scaled rows, so has lengtha%mnota%n. Basically same as #211