Skip to content

Commit

Permalink
Adding aria label for include/exclude selector button #772
Browse files Browse the repository at this point in the history
This now makes the screen reader say 'clickable include or exclude menu button sub menu' compared to 'clickable menu button sub menu'. This is a minor improvement, could be made better
  • Loading branch information
Sam Glendenning committed Aug 25, 2021
1 parent 423787e commit 9b6dab0
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ const TextColumnFilter = (props: {
// Do not render a value
renderValue={() => ''}
onChange={(e) => handleSelectChange(e.target.value as string)}
SelectDisplayProps={{
'aria-label': `include or exclude`,
}}
>
<MenuItem
key="include"
Expand Down

0 comments on commit 9b6dab0

Please sign in to comment.