Don't free memory not allocated by getaddrinfo(3) with freeaddrinfo #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai_unique_ptr frees objects via a custom deleter using freeaddrinfo(3). However, in ai_make_hint the ai_unique_ptr is used for a addrinfo structure allocated via new. This is undefined behavior as freeaddrinfo is only defined for structures returned by getaddrinfo(). This commit fixes this by using a standard std::unique_ptr here with the default delete function which frees the memory using delete.
Closed
|
use std::make_unique |
neheb
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ai_unique_ptrfrees objects via a custom deleter usingfreeaddrinfo(3). However, inai_make_hinttheai_unique_ptris used for aaddrinfostructure allocated vianew. This is undefined behavior asfreeaddrinfo(3)is only defined for structures returned bygetaddrinfo(3).This commit fixes this by using a standard
std::unique_ptrhere with the default delete function which frees the memory usingdelete.Just like #319 this has been discovered due to test failures on certain Alpine Linux Edge architectures.