-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: update parameters for substr helper
- Loading branch information
Showing
3 changed files
with
30 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,12 @@ jobs: | |
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12 | ||
| - run: npm install | ||
| - run: npm run lint:js | ||
| - run: npm run lint:hbs | ||
| - run: npm test | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 4.11.1 | ||
| run_install: | | ||
| - recursive: true | ||
| args: [--frozen-lockfile, --strict-peer-dependencies] | ||
| - run: pnpm run lint:js | ||
| - run: pnpm run lint:hbs | ||
| - run: pnpm test | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import { helper } from '@ember/component/helper'; | ||
| import { substr } from 'voca'; | ||
|
|
||
| export default helper(function vocaSubstr(params/*, hash */ ) { | ||
| return substr(params[0]); | ||
| export default helper(function vocaSubstr(params ) { | ||
| return substr(params[0], params[1], params[2]); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,23 @@ | ||
|
|
||
| <h3>voca-substr:</h3> | ||
| <p>Description for voca-substr goes here.</p> | ||
| <p> | ||
| <h3>voca-substr:</h3> | ||
| <hr> | ||
| <p>Description for voca-substr goes here.</p> | ||
| <p> | ||
| <code> | ||
| \{{ voca-substr "hello world"}} | ||
| \{{ voca-substr "infinite loop" 9}} | ||
| </code> | ||
| </p> | ||
| <p> | ||
| </p> | ||
| <p> | ||
| <code> | ||
| // => {{ voca-substr "hello world"}} | ||
| // => {{ voca-substr "infinite loop" 9}} | ||
| </code> | ||
| </p> | ||
| </p> | ||
| <p> | ||
| <code> | ||
| \{{ voca-substr "dreams" 2 2}} | ||
| </code> | ||
| </p> | ||
| <p> | ||
| <code> | ||
| // => {{ voca-substr "dreams" 2 2}} | ||
| </code> | ||
| </p> |