Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current user as default publisher #464

Merged
merged 4 commits into from
Sep 10, 2019
Merged

Use current user as default publisher #464

merged 4 commits into from
Sep 10, 2019

Conversation

rubenvanerk
Copy link
Contributor

Fix for #463

models/Post.php Outdated Show resolved Hide resolved
@bennothommo bennothommo added Status: Testing Needed Requires testing before it can be accepted Type: Maintenance Minor maintenance to the code base (i.e. minor bug fixes, styling fixes, translation improvements) labels Sep 6, 2019
models/Post.php Outdated Show resolved Hide resolved
models/Post.php Outdated Show resolved Hide resolved
models/Post.php Outdated Show resolved Hide resolved
@bennothommo bennothommo added the Status: Revision Needed Requires changes before it can be accepted label Sep 6, 2019
- Moved comments
- Explicit check context
- Don't override selection made in form
models/Post.php Outdated Show resolved Hide resolved
@bennothommo bennothommo removed Status: Revision Needed Requires changes before it can be accepted Status: Testing Needed Requires testing before it can be accepted labels Sep 9, 2019
@bennothommo
Copy link
Contributor

@rubenvanerk Looks fine to me, tested and working correctly. @LukeTowers, do you have any further feedback?

@LukeTowers
Copy link
Contributor

@rubenvanerk nope, LGTM! Good job @rubenvanerk!

@bennothommo bennothommo added the Status: Completed Fix is completed and merged into the dev branch; remaining open until it has been merged into master label Sep 10, 2019
@bennothommo bennothommo added this to the v.1.3.4 milestone Sep 10, 2019
@bennothommo bennothommo merged commit 7b3b8c0 into rainlab:master Sep 10, 2019
@bennothommo
Copy link
Contributor

Nice work @rubenvanerk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Fix is completed and merged into the dev branch; remaining open until it has been merged into master Type: Maintenance Minor maintenance to the code base (i.e. minor bug fixes, styling fixes, translation improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants