Update vulnerable js libs #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating these vulnerable JS libs:
With the jQuery update I've had to also update
jquery.pjaxlib, addjQuery.migratelib and did some tweaks to existing js code which was not working properly with jQuery3.Tests are passing for just 1 environment – the failing tests seems to be unrelated to this update.
We did this update for our company project, on first sight everything seems to be working. However the update of jQuery to v3 is huge and it is possible it's breaking something in the admin. Will be glad for feedback in case we've missed some functionality.